Skip to content

DEV-1163 Add ShimmerObject.setLSM6DSVAccelRange for the Shimmer3R SD log parser - #322

Merged
MAzalya merged 1 commit into
masterfrom
DEV-1163_shimmer3r_sd_ln_accel_range
Oct 9, 2026
Merged

MAzalya merged 1 commit into
masterfrom
DEV-1163_shimmer3r_sd_ln_accel_range

Conversation

@JongChern

Copy link
Copy Markdown
Contributor

Summary

Adds a protected ShimmerObject.setLSM6DSVAccelRange(int), alongside the existing setLSM6DSVGyroRange(int).

The Shimmer3R SD log parser (ShimmerSDLog in Shimmer-Advance-API) needs to set the low-noise accel (LSM6DSV) range it reads from the file header. It had no way to: mSensorLSM6DSV is private, and on Shimmer3R ShimmerObject.setAccelRange sets the wide-range accel (LIS2DW12), not the LN accel.

This is additive only. Nothing in this repo calls it yet.

Why

Shimmer3R SD logs recorded with the LN accel at ±4g, ±8g or ±16g were parsed as ±2g, because the parser never read the range from the header. The companion PR in Shimmer-Advance-API makes the parser read it and uses this setter.

Merge order

Merge this first. Shimmer-Advance-API's CI builds against this repo's master, so the companion PR will not compile until this is merged.

Testing

The companion PR's test (ADV_API_00083_ShimmerSDLogLnAccelRangeTest) drives this setter through ShimmerSDLog. It passes with this change and fails without the parser fix.

🤖 Generated with Claude Code

Lets the Shimmer3R SD log parser set the low-noise accel (LSM6DSV)
range from the file header, as setLSM6DSVGyroRange does for the gyro.
mSensorLSM6DSV is private, and ShimmerObject.setAccelRange sets the
wide-range accel on Shimmer3R, so there was no way to reach it.

Co-Authored-By: Claude Opus 5.5 <[email protected]>

@MAzalya MAzalya left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok tested, looks good

@MAzalya
MAzalya merged commit c1d7078 into master Oct 9, 2026
2 of 3 checks passed
@MAzalya
MAzalya deleted the DEV-1163_shimmer3r_sd_ln_accel_range branch October 9, 2026 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants