Repository navigation
DEV-1163 Add ShimmerObject.setLSM6DSVAccelRange for the Shimmer3R SD log parser - #322
Merged
Merged
Conversation
Lets the Shimmer3R SD log parser set the low-noise accel (LSM6DSV) range from the file header, as setLSM6DSVGyroRange does for the gyro. mSensorLSM6DSV is private, and ShimmerObject.setAccelRange sets the wide-range accel on Shimmer3R, so there was no way to reach it. Co-Authored-By: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a protected
ShimmerObject.setLSM6DSVAccelRange(int), alongside the existingsetLSM6DSVGyroRange(int).The Shimmer3R SD log parser (
ShimmerSDLogin Shimmer-Advance-API) needs to set the low-noise accel (LSM6DSV) range it reads from the file header. It had no way to:mSensorLSM6DSVis private, and on Shimmer3RShimmerObject.setAccelRangesets the wide-range accel (LIS2DW12), not the LN accel.This is additive only. Nothing in this repo calls it yet.
Why
Shimmer3R SD logs recorded with the LN accel at ±4g, ±8g or ±16g were parsed as ±2g, because the parser never read the range from the header. The companion PR in Shimmer-Advance-API makes the parser read it and uses this setter.
Merge order
Merge this first. Shimmer-Advance-API's CI builds against this repo's
master, so the companion PR will not compile until this is merged.Testing
The companion PR's test (
ADV_API_00083_ShimmerSDLogLnAccelRangeTest) drives this setter throughShimmerSDLog. It passes with this change and fails without the parser fix.🤖 Generated with Claude Code